Feature #189

Improve rcon rate limiting

Added by msk 3 months ago. Updated 3 months ago.

Status:New Start date:02/07/2012
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:-
Target version:-

Description

Currently, how a large amount of commands is handled with rcon is
  1. The first 0<=x<=10 commands are sent immediately
  2. Each remaining command is sent with a delay
This makes two important changes
  1. Commands are only sent at the start of the read loop
  2. As many queued commands as possible are sent in a single packet

"Sent: blah" becomes spammy when more than one command is sent at once, so this changes it to "Sent x commands in y characters" when multiple commands are sent simultaneously

This is necessary for future improvements I'm planning for CommandQueue

cq2.patch - CommandQueue improvements (1.8 kB) msk, 02/07/2012 11:22 am

History

#1
Updated by msk 3 months ago

I figured I should explain this better: currently each command is sent in its own packet. By sending multiple commands in each packet, this more closely matches the leaky bucket implementation in the server, to allow an arbitrary number of commands in quick succession (up to a certain cumulative length). This also generally empties the send queue faster

Also available in: Atom PDF